Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure factor normalization update #83

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

DomFijan
Copy link
Contributor

Description

Add another normalization scheme to examples based on the discussion in the freud issue. Also see glotzerlab/freud#1314

Resolves: glotzerlab/freud#1313

Checklist:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@DomFijan DomFijan marked this pull request as ready for review February 28, 2025 04:15
@DomFijan DomFijan requested review from a team, j-proc and joaander and removed request for a team February 28, 2025 04:15
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DomFijan DomFijan merged commit f7c181d into master Mar 3, 2025
2 checks passed
@DomFijan DomFijan deleted the structure_factor_normalization branch March 3, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faber-Ziman Partial Structure Factors Normalization
2 participants