Enable flake8 for MPCD #1741
Merged
Enable flake8 for MPCD #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mphoward
commented
Mar 13, 2024
mphoward
commented
Mar 13, 2024
mphoward
commented
Mar 13, 2024
mphoward
requested review from
a team,
joaander,
tommy-waltmann and
Tobias-Dwyer
and removed request for
a team
|
This one should be ready now too! |
tommy-waltmann
approved these changes
Mar 19, 2024
joaander
added
the
validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reenables flake8 checks on the MPCD code. I also fixed errors that were identified.
Motivation and context
We didn't have this on before, and MPCD should be fully compliant with HOOMD's style.
How has this been tested?
N/A
Change log
N/A
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.