Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test compiled union potential. #86

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Test compiled union potential. #86

merged 3 commits into from
Mar 19, 2024

Conversation

joaander
Copy link
Member

Description

Test the compiled union potential added in glotzerlab/hoomd-blue#1725.

Motivation and context

Ensure that the new code operations correctly.

How has this been tested?

I executed the lj_union subproject:
lj_union_compare_kT1 5_density0 04
lj_union_distribution_analyze_kT1 5_density0 04

Checklist:

@joaander joaander marked this pull request as ready for review March 6, 2024 21:35
@joaander joaander requested review from a team, SchoeniPhlippsn and tommy-waltmann and removed request for a team March 6, 2024 21:35
@tommy-waltmann
Copy link
Collaborator

Is it typical for some integration method/thermostat combinations to have error bars slightly outside the accepted value?

@joaander
Copy link
Member Author

joaander commented Mar 7, 2024

Is it typical for some integration method/thermostat combinations to have error bars slightly outside the accepted value?

Yes. The statistical sampling leads to a variety of measured means depending on seed and other factors. The "known" means for P, rho, and U are also a sampled value with unknown error bars (assumed 0 here), so the shown error bars are actually smaller then they should be by an unknown amount. If we assume that the error on the known mean is similar to the error on the measured mean, then the error bars should be off the dotted line ~40% of the time.

The known mean for is exact. The large spread and mean deviation for MTTK shows that MTTK is not as accurate as Bussi.

When these tests fail, they fail obviously - with means many tens of error bars of separation and clearly distinct distributions in the histogram plots.

@joaander joaander merged commit 927c93d into trunk Mar 19, 2024
2 checks passed
@joaander joaander deleted the compiled-union-potential branch March 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants