Skip to content

Commit

Permalink
Don't start gluwa/hardhat-dev when testing against disconnected node
Browse files Browse the repository at this point in the history
the creditcoin-node is isolated from the rest of the blockchain however
it is still configured to search for Ethereum transfers on Sepolia,
the same as Testnet! Running the hardhat container here is useless.
  • Loading branch information
atodorov committed Jan 18, 2024
1 parent 4e7a606 commit 76c3d7c
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions .github/workflows/runtime-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -466,14 +466,6 @@ jobs:
run: |
./scripts/wait-for-sync.sh ${{ needs.setup.outputs.last_block_number }}
- name: Install Docker engine
run: |
./scripts/install-docker-engine-from-upstream.sh
- name: Start local Ethereum node
run: |
sudo docker run --name hardhat-dev --rm -p 8545:8545 -d gluwa/hardhat-dev
- name: Install Node.js
uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -543,11 +535,6 @@ jobs:
name: logs
path: "*.log"

- name: Kill hardhat-dev
if: always()
run: |
sudo docker kill hardhat-dev
- name: Kill creditcoin-node
run: |
# if all went well kill the node. Otherwise GitHub Actions would exit on the
Expand Down

0 comments on commit 76c3d7c

Please sign in to comment.