CSUB-980: Adjust contract addresses for testing against Devnet & Testnet #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1508 +/- ##
==========================================
+ Coverage 71.47% 72.53% +1.05%
==========================================
Files 107 107
Lines 12561 12561
Branches 128 128
==========================================
+ Hits 8978 9111 +133
+ Misses 3583 3440 -143
- Partials 0 10 +10 ☔ View full report in Codecov by Sentry. |
WARNING: There are two contracts on Sepolia for each token (G-CRE & GATE). Devnet & Testnet use the same GCRE contract however it has been deployed twice and offchain workers for each network are configured differently! - ETHEREUM_NODE_URL in 1Password has been updated - TESTNET_ETHEREUM_NODE_URL secret in GitHub has been updated
atodorov
force-pushed
the
testing/CSUB-980-testing-against-devnet
branch
from
a76948f to
46da8ec
Compare
the creditcoin-node is isolated from the rest of the blockchain however it is still configured to search for Ethereum transfers on Sepolia, the same as Testnet! Running the hardhat container here is useless.
because during runtime-upgrade tests we're using `testnet.config.ts` when running against a disconnected-node locally, however the connection URL needs to be ws://127.0.0.1:9944.
we're using `testnet.config.ts` however the connection URL needs to be ws://127.0.0.1:9944 because this isn't supposed to go outside of the local machine!
atodorov
force-pushed
the
testing/CSUB-980-testing-against-devnet
branch
from
46da8ec to
32e0043
Compare
atodorov
requested review from
nathanwhit,
pLabarta,
zacharyfrederick and
frankli-dev
pLabarta
approved these changes
Jan 16, 2024
zacharyfrederick
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: