Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: referral #459

Merged
merged 11 commits into from
Jan 19, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update remove
  • Loading branch information
notJoon committed Jan 19, 2025
commit 2913e6625d948841b870d3b34be39be2d2b26776
4 changes: 4 additions & 0 deletions referral/keeper.gno
Original file line number Diff line number Diff line change
@@ -102,6 +102,10 @@ func (k *keeper) remove(target std.Address) error {
return err
}

if err := k.checkRateLimit(target.String()); err != nil {
return err
}

if !target.IsValid() {
return NewError(ErrInvalidAddress)
}
78 changes: 0 additions & 78 deletions referral/keeper_test.gno
Original file line number Diff line number Diff line change
@@ -73,13 +73,6 @@ func TestRegister(t *testing.T) {
wantErr: true,
errCode: ErrSelfReferral,
},
{
name: "zero address referral",
addr: validAddr1,
refAddr: zeroAddress,
setupCaller: mockValidCaller,
wantErr: false,
},
}

for _, tt := range tests {
@@ -149,16 +142,6 @@ func TestUpdate(t *testing.T) {
wantErr: true,
errCode: ErrSelfReferral,
},
{
name: "update to zero address",
addr: validAddr1,
refAddr: zeroAddress,
setupState: func(k *keeper) {
k.store.Set(validAddr1.String(), validAddr2.String())
},
setupCaller: mockValidCaller,
wantErr: false,
},
}

for _, tt := range tests {
@@ -373,67 +356,6 @@ func TestUpdateNonExistentReferral(t *testing.T) {
}
}

func TestDuplicateRegistration(t *testing.T) {
k := setupKeeper()
cleanup := mockValidCaller()
defer cleanup()

originalTimeNow := time.Now
time.Now = mockTimeNow
defer func() { time.Now = originalTimeNow }()

err := k.register(validAddr1, validAddr2)
if err != nil {
t.Fatalf("First registration failed: %v", err)
}

currentTime += MinTimeBetweenUpdates + 1

err = k.register(validAddr1, validAddr2)
if err != nil {
t.Errorf("Duplicate registration should succeed, got error: %v", err)
}

refAddr, err := k.get(validAddr1)
if err != nil || refAddr != validAddr2 {
t.Errorf("Original referral was not preserved")
}
}

// TODO: Chained references seem to need discussion.
func TestChainedReferrals(t *testing.T) {
k := setupKeeper()
cleanup := mockValidCaller()
defer cleanup()

addr1 := testutils.TestAddress("addr1")
addr2 := testutils.TestAddress("addr2")
addr3 := testutils.TestAddress("addr3")

// A -> B -> C
err := k.register(addr1, addr2)
if err != nil {
t.Fatalf("Failed to register addr1->addr2: %v", err)
}

err = k.register(addr2, addr3)
if err != nil {
t.Fatalf("Failed to register addr2->addr3: %v", err)
}

// remove middle node (B)
err = k.remove(addr2)
if err != nil {
t.Fatalf("Failed to remove addr2: %v", err)
}

// A -> C
refAddr, err := k.get(addr1)
if err != nil || refAddr != addr2 {
t.Error("addr1's referral should still point to addr2")
}
}

func TestReferralCycles(t *testing.T) {
k := setupKeeper()
cleanup := mockValidCaller()
Loading