-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reward ratio calculation #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
956ba16
to
e3a1a46
Compare
…om/gnoswap-labs/gnoswap into mconcat/staker-reward-optimization
…ap-labs/gnoswap into mconcat/staker-reward-optimization
notJoon
reviewed
Jan 19, 2025
dongwon8247
reviewed
Jan 19, 2025
…ap-labs/gnoswap into mconcat/staker-reward-optimization
notJoon
reviewed
Jan 19, 2025
|
dongwon8247
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
notJoon
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
moul
pushed a commit
that referenced
this pull request
Jan 20, 2025
* add reward ratio calculation * reward ratio logic works * prototyping * remove unncesary comments * callback: emission * warmup works * save * warmup with test works * add reward ratio calculation * reward ratio logic works * warmup works * warmup with test works * external reward WIP * add callbacks * test works * remove unused code * rename * prototyping * remove unncesary comments * callback: emission * save * add callbacks * test works * remove unused code * rename * internal + emission working * fix: emission callback panic issue * fix: callbackStakerEmissionChange is nil * emission change applied works * external reward works * fix emission * external unclaimable works * test: full test * fix modifyDeposit * test: full test update * fix * fix * test : test code update * fix : pool tier * fix: full test // wip * fix: missing init // by @mconcat * fix: full test // wip * fix: nil error when pool has only external incentive * fix: external incentive is not being calculated * fix: full test // most of tc runs good, reward amount seems ok // wip * fix: full test // emission reward comparing * fix: check amount with error range 99.99% * fix: every test functino to check gns balance (and external reward amount if necessary) * chore: rename * test(fix): __TEST_more_01 * test(fix): __TEST_more_02 * test(fix): __TEST_more_04 * test(fix): fix test cases * fix: when collecting reward, unwrapping should be supported for ugnot coin * chore: rename * update canonical env * fix callback nil * test(fix): external gnoA * test(fix): staker full test with all reward calculated * chore * test(fix): adjust deposit amount (co-author: @mconcat) * test(fix): fix internal gnoA * test(fix): fix test * add comments, remove unused code * test(feat): pool with internal reward + external gns * test(chore): remove duplicated scenario * remove unnecesary comment * reimplement api.gno * feat: remove unused cross (co-author: @mconcat) * fix: `ApiGetRewardTokens()` not to early return * remove debug lines * remove unused lines * resolve TODOs * readme wip * readme * readme * readme --------- Co-authored-by: Lee ByeongJun <lbj199874@gmail.com> Co-authored-by: 0xTopaz <myunghwan@onbloc.xyz> Co-authored-by: n3wbie <r3v4@onbloc.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.