Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/manage protocol fee list #464

Merged
merged 7 commits into from
Jan 19, 2025
Merged

feat/manage protocol fee list #464

merged 7 commits into from
Jan 19, 2025

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jan 17, 2025

Description

  1. protocol_fee manages accumulated token path with its amount

to avoid iterating (entire) registered token list

  1. each contract which send certain amount to protocol_fee contract has to set which token and how much has been sent

@r3v4s r3v4s added enhancement New feature or request protocol_fee labels Jan 17, 2025
@r3v4s r3v4s requested review from notJoon, onlyhyde and mconcat January 17, 2025 06:27
@r3v4s r3v4s self-assigned this Jan 17, 2025
protocol_fee/token_list_with_amount.gno Outdated Show resolved Hide resolved
protocol_fee/token_list_with_amount.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s requested a review from onlyhyde January 19, 2025 01:49
Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
@onlyhyde onlyhyde merged commit 10c5dd8 into main Jan 19, 2025
1 of 2 checks passed
@onlyhyde onlyhyde deleted the feat/manage-protocol-fee-list branch January 19, 2025 07:41
moul pushed a commit that referenced this pull request Jan 20, 2025
* feat: manage accumulated protocol_fee list
* feat: `pool` adds token(+amount) to protocol_fee
* feat: `router` adds token(+amount) to protocol_fee
* feat: `staker` adds token(+amount) to protocol_fee
* fix: amount and balance checking

---------

Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request protocol_fee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants