Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: event message change #483

Merged
merged 5 commits into from
Jan 24, 2025
Merged

refactor: event message change #483

merged 5 commits into from
Jan 24, 2025

Conversation

onlyhyde
Copy link
Member

No description provided.

@onlyhyde onlyhyde requested review from r3v4s, mconcat and notJoon January 22, 2025 06:32
notJoon
notJoon previously approved these changes Jan 22, 2025
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event seems be more detailed than before, LGTM.
However, found some minor issues.

@r3v4s r3v4s self-requested a review January 23, 2025 02:02
r3v4s
r3v4s previously approved these changes Jan 23, 2025
@onlyhyde onlyhyde dismissed stale reviews from r3v4s and notJoon via 24685a6 January 23, 2025 02:05
@r3v4s r3v4s requested review from r3v4s and notJoon January 23, 2025 02:17
r3v4s
r3v4s previously approved these changes Jan 23, 2025
dongwon8247
dongwon8247 previously approved these changes Jan 23, 2025
notJoon
notJoon previously approved these changes Jan 23, 2025
@onlyhyde onlyhyde dismissed stale reviews from notJoon, dongwon8247, and r3v4s via 59b203d January 23, 2025 08:25
@onlyhyde onlyhyde self-assigned this Jan 23, 2025
@onlyhyde onlyhyde merged commit fdee3db into main Jan 24, 2025
1 of 2 checks passed
@onlyhyde onlyhyde deleted the refactor/event-message branch January 24, 2025 02:50
moul pushed a commit that referenced this pull request Jan 24, 2025
* refactor: event message change
* refactor: staker event
* refactor: staker and gns event update

---------

Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants