-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSW-2080 docs: update comments #488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongwon8247
reviewed
Jan 31, 2025
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
notJoon
previously approved these changes
Feb 3, 2025
dongwon8247
reviewed
Feb 3, 2025
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
This was referenced Feb 3, 2025
dongwon8247
approved these changes
Feb 3, 2025
dongwon8247
previously approved these changes
Feb 3, 2025
onlyhyde
reviewed
Feb 3, 2025
Quality Gate passedIssues Measures |
onlyhyde
approved these changes
Feb 3, 2025
notJoon
approved these changes
Feb 3, 2025
r3v4s
added a commit
that referenced
this pull request
Feb 4, 2025
* docs: comments, docs, ... * chore: unify block interval to ms * chore: milliToSec() to convert milisecond to second
onlyhyde
pushed a commit
that referenced
this pull request
Feb 5, 2025
* test: txtar deploy testing * doc (#490) * GSW-2080 docs: update comments (#488) * docs: comments, docs, ... * chore: unify block interval to ms * chore: milliToSec() to convert milisecond to second * refactor: gnsmath (#489) * refactor: gnsmath Co-authored-by: Lee ByeongJun <lbj199874@gmail.com> Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More comments so code can be more easily understand.
Made time related variable name to be more clear.
Clean up non used code.