Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-2080 docs: update comments #488

Merged
merged 15 commits into from
Feb 3, 2025
Merged

GSW-2080 docs: update comments #488

merged 15 commits into from
Feb 3, 2025

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jan 31, 2025

Description

More comments so code can be more easily understand.
Made time related variable name to be more clear.
Clean up non used code.

contract/p/gnoswap/consts/consts.gno Outdated Show resolved Hide resolved
contract/p/gnoswap/consts/consts.gno Show resolved Hide resolved
contract/r/gnoswap/position/position.gno Outdated Show resolved Hide resolved
r3v4s and others added 5 commits February 1, 2025 21:29
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
@r3v4s r3v4s changed the title (wip) update comments GSW-2080 docs: update comments Feb 1, 2025
@r3v4s r3v4s self-assigned this Feb 1, 2025
@r3v4s r3v4s marked this pull request as ready for review February 1, 2025 12:56
notJoon
notJoon previously approved these changes Feb 3, 2025
contract/p/gnoswap/consts/consts.gno Outdated Show resolved Hide resolved
contract/p/gnoswap/consts/consts.gno Show resolved Hide resolved
contract/p/gnoswap/consts/consts.gno Outdated Show resolved Hide resolved
contract/p/gnoswap/consts/consts.gno Show resolved Hide resolved
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
@r3v4s r3v4s requested review from dongwon8247 and notJoon February 3, 2025 07:21
dongwon8247
dongwon8247 previously approved these changes Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

@r3v4s r3v4s merged commit 772829f into main Feb 3, 2025
18 of 19 checks passed
@r3v4s r3v4s deleted the docs/comments branch February 3, 2025 09:20
r3v4s added a commit that referenced this pull request Feb 4, 2025
* docs: comments, docs, ...
* chore: unify block interval to ms
* chore: milliToSec() to convert milisecond to second
onlyhyde pushed a commit that referenced this pull request Feb 5, 2025
* test: txtar deploy testing
* doc (#490)
* GSW-2080 docs: update comments (#488)
* docs: comments, docs, ...
* chore: unify block interval to ms
* chore: milliToSec() to convert milisecond to second
* refactor: gnsmath (#489)
* refactor: gnsmath

Co-authored-by: Lee ByeongJun <lbj199874@gmail.com>
Co-authored-by: Dongwon <74406335+dongwon8247@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants