Fix setState so it handles values #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,13 @@ export function createStoreConfig(globalConfig, StoreModel) { | |||
| return state | |||
| } | |||
| }, | |||
| setState: fn.assign | |||
| setState(currentState, nextState) { | |||
| if (Object.prototype.toString.call(nextState) === '[object Object]') { | |||
There was a problem hiding this comment.
Maybe pull this out into a fn.isPlainObject? You use it e.g. at
Line 50 in 44d5814
There was a problem hiding this comment.
yeah fn.isPlainObject sounds like a good idea. Not sure if I should merge #468 or not. It's a bit dirty to add a property to alt stores and check for them.
There was a problem hiding this comment.
With something like #344 it could be a non-issue as you could potentially have a separate overriding implementation of getState for stores holding immutable data.
There was a problem hiding this comment.
Yeah, but #344 opens a whole can of worms in how state is managed and exposes a lot of internals. I'm still conflicted on it.
Conflicts: src/alt/store/index.js
goatslacker
force-pushed
the
fix-set-state-so-it-handles-values
branch
from
451409e to
b1d6622
Compare
|
Fixes #468 |
goatslacker
added a commit
that referenced
this pull request
Oct 3, 2015
…values Fix setState so it handles values
This was referenced Oct 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a store that has state that is a value and not an object we still want to be able to use this.setState