TEST: send comment tests to real database (#191)

comments_test.go

@@ -1,14 +1,14 @@
 package dbr
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/gocraft/dbr/v2/dialect"
 	"github.com/stretchr/testify/require"
 )
 
 func TestComments(t *testing.T) {
-	dialects := []Dialect{dialect.MySQL, dialect.PostgreSQL, dialect.SQLite3}
 	for _, test := range []struct {
 		name     string
 		comments Comments
@@ -31,22 +31,34 @@ func TestComments(t *testing.T) {
 		},
 	} {
 
-		for _, d := range dialects {
+		for _, sess := range testSession {
 			name := ""
-			switch d {
+			switch sess.Dialect {
 			case dialect.MySQL:
 				name = "MySQL"
 			case dialect.PostgreSQL:
 				name = "PostgreSQL"
 			case dialect.SQLite3:
 				name = "SQLite3"
 			}
-			t.Run(name+" "+test.name, func(t *testing.T) {
+			t.Run(fmt.Sprintf("%s/%s", name, test.name), func(t *testing.T) {
 				buf := NewBuffer()
-				test.comments.Build(d, buf)
+				err := test.comments.Build(sess.Dialect, buf)
+				require.NoError(t, err)
 				require.Equal(t, test.expect, buf.String())
+
+				stmt := sess.Select("1")
+				stmt.comments = test.comments
+
+				buf2 := NewBuffer()
+				err = stmt.Build(sess.Dialect, buf2)
+				require.NoError(t, err)
+				require.Equal(t, test.expect+"SELECT 1", buf2.String())
+
+				one, err := stmt.ReturnInt64()
+				require.NoError(t, err)
+				require.EqualValues(t, 1, one)
 			})
 		}
 	}
-
 }

delete.go

@@ -32,7 +32,10 @@ func (b *DeleteStmt) Build(d Dialect, buf Buffer) error {
 		return ErrTableNotSpecified
 	}
 
-	b.comments.Build(d, buf)
+	err := b.comments.Build(d, buf)
+	if err != nil {
+		return err
+	}
 
 	buf.WriteString("DELETE FROM ")
 	buf.WriteString(d.QuoteIdent(b.Table))

insert.go

@@ -38,7 +38,10 @@ func (b *InsertStmt) Build(d Dialect, buf Buffer) error {
 		return ErrColumnNotSpecified
 	}
 
-	b.comments.Build(d, buf)
+	err := b.comments.Build(d, buf)
+	if err != nil {
+		return err
+	}
 
 	buf.WriteString("INSERT INTO ")
 	buf.WriteString(d.QuoteIdent(b.Table))

select.go

@@ -43,7 +43,10 @@ func (b *SelectStmt) Build(d Dialect, buf Buffer) error {
 		return ErrColumnNotSpecified
 	}
 
-	b.comments.Build(d, buf)
+	err := b.comments.Build(d, buf)
+	if err != nil {
+		return err
+	}
 
 	buf.WriteString("SELECT ")
 

update.go

@@ -37,7 +37,10 @@ func (b *UpdateStmt) Build(d Dialect, buf Buffer) error {
 		return ErrColumnNotSpecified
 	}
 
-	b.comments.Build(d, buf)
+	err := b.comments.Build(d, buf)
+	if err != nil {
+		return err
+	}
 
 	buf.WriteString("UPDATE ")
 	buf.WriteString(d.QuoteIdent(b.Table))