Skip to content

Commit

Permalink
refactor: replace createRequire with import for package.json
Browse files Browse the repository at this point in the history
  • Loading branch information
aryasaatvik committed Jan 27, 2025
1 parent 040e466 commit d433e48
Show file tree
Hide file tree
Showing 24 changed files with 50 additions and 78 deletions.
4 changes: 1 addition & 3 deletions packages/create-gasket-app/lib/index.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
#!/usr/bin/env node
import { Command } from 'commander';
import { createRequire } from 'module';
import pkg from '../package.json' with { type: 'json' };
import { createCommand } from './commands/create.js';
import { processCommand, logo } from './utils/index.js';
import { warnIfOutdated } from '@gasket/utils';

const require = createRequire(import.meta.url);
const pkg = require('../package.json');
const program = new Command();

// Create Gasket CLI
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-command/lib/cli.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { Command } from 'commander';
import { logo } from './utils/logo.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { version } = pkg;
const program = new Command();

// Create Gasket CLI
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-command/lib/create.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
/// <reference types="create-gasket-app" />

import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

/** @type {import('@gasket/core').HookHandler<'create'>} */
export default function create(gasket, { pkg, gasketConfig }) {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-command/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ import configure from './configure.js';
import prepare from './prepare.js';
import commands from './commands.js';
import ready from './ready.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

/** @type {import('@gasket/core').Plugin} */
export default {
Expand Down
6 changes: 2 additions & 4 deletions packages/gasket-plugin-command/test/cli.test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import { createRequire } from 'module';
import { gasketBin } from '../lib/cli';
import { processCommand } from '../lib/utils/process-command';

const require = createRequire(import.meta.url);
const { version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { version } = pkg;

describe('cli', () => {
it('should have a gasketBin property', () => {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-command/test/create.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { jest } from '@jest/globals';
import create from '../lib/create.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

describe('create', () => {
let mockContext;
Expand Down
6 changes: 2 additions & 4 deletions packages/gasket-plugin-command/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import plugin from '../lib/index.js';
import { createRequire } from 'module';

const require = createRequire(import.meta.url);
const { name, version, description } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

describe('@gasket/plugin-command', () => {
it('should export an object', () => {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-dynamic-plugins/lib/index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
/// <reference types="@gasket/plugin-metadata" />

import prepare from './prepare.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

/** @type {import('@gasket/core').Plugin} */
export default {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-https-proxy/lib/create.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

/** @type {import('@gasket/core').HookHandler<'create'>} */
export default function create(gasket, { pkg, gasketConfig }) {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-https-proxy/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@

import create from './create.js';
import { actions } from './actions.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

/** @type {import('@gasket/core').Plugin} */
export default {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-https-proxy/test/create.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { vi, describe, it, expect, beforeEach } from 'vitest';
import plugin from '../lib/index.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

describe('create', () => {
let mockContext;
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-https-proxy/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { describe, it, expect, beforeEach } from 'vitest';
import plugin from '../lib/index.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

describe('Plugin', function () {
let gasket;
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-metadata/lib/create.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

/** @type {import('@gasket/core').HookHandler<'create'>} */
export default function create(gasket, { pkg, gasketConfig }) {
Expand Down
13 changes: 6 additions & 7 deletions packages/gasket-plugin-metadata/lib/index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import create from './create.js';
import actions from './actions.js';
import webpackConfig from './webpack-config.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
import corePkg from '@gasket/core/package.json' with { type: 'json' };
const { name, version, description } = pkg;

/** @type {import('@gasket/core').Plugin} */
export default ({
Expand All @@ -15,7 +15,6 @@ export default ({
create,
webpackConfig,
metadata(gasket, meta) {
const mod = require('@gasket/core/package.json');
return {
...meta,
actions: [
Expand All @@ -34,9 +33,9 @@ export default ({
}],
modules: [
{
name: mod.name,
version: mod.version,
description: mod.description,
name: corePkg.name,
version: corePkg.version,
description: corePkg.description,
link: 'README.md'
}
]
Expand Down
6 changes: 2 additions & 4 deletions packages/gasket-plugin-metadata/lib/webpack-config.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
/// <reference types="@gasket/plugin-webpack" />

import { createRequire } from 'module';
const require = createRequire(import.meta.url);

const { name } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name } = pkg;

/** @type {import('@gasket/core').HookHandler<'webpackConfig'>} */
export default function webpackConfigHook(gasket, webpackConfig) {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-metadata/test/create.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { vi } from 'vitest';
import plugin from '../lib/index.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version } = require('../package');
import pkg from '../package.json' with { type: 'json' };
const { name, version } = pkg;

describe('create', () => {
let mockContext;
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-metadata/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
/* eslint-disable max-statements */
import plugin from '../lib/index.js';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

describe('Plugin', function () {
let gasket;
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-plugin-metadata/test/webpack-config.test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import webpackConfigHook from '../lib/webpack-config';
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { name } = require('../package');
import pkg from '../package.json' with { type: 'json' };
const { name } = pkg;

describe('webpackConfig', function () {
let mockGasket, mockWebpackConfig;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import IndexPage from '../pages/index.js';
import { expect } from '@jest/globals';
{{#if hasGasketIntl}}
import { IntlProvider } from 'react-intl';
import { createRequire } from 'module';
const messages = createRequire(import.meta.url)('../locales/en-US.json');
import messages from '../locales/en-US.json' with { type: 'json' };
{{/if}}

describe('IndexPage', () => {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-preset-api/lib/create.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import path from 'path';
import { createRequire } from 'module';
import { fileURLToPath } from 'url';
const require = createRequire(import.meta.url);
const { devDependencies } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { devDependencies } = pkg;

/** @type {import('@gasket/core').HookHandler<'create'>} */
export default function create(gasket, context) {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-preset-api/lib/index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { createRequire } from 'module';
import presetPrompt from './preset-prompt.js';
import presetConfig from './preset-config.js';
import create from './create.js';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

/** @type {import('@gasket/core').Preset} */
export default {
Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-preset-api/test/create.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { jest } from '@jest/globals';
import { createRequire } from 'module';
import preset from '../lib/index.js';
const require = createRequire(import.meta.url);
const { devDependencies } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { devDependencies } = pkg;
const mockPkgAdd = jest.fn();
const mockFilesAdd = jest.fn();

Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-preset-api/test/index.test.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
import preset from '../lib/index.js';
import pkg from '../package.json' with { type: 'json' };
const {
name,
version,
description,
dependencies
} = require('../package.json');
} = pkg;

describe('gasket-preset-api', () => {

Expand Down
5 changes: 2 additions & 3 deletions packages/gasket-preset-nextjs/lib/index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { createRequire } from 'module';
import presetPrompt from './preset-prompt.js';
import presetConfig from './preset-config.js';
import create from './create.js';
const require = createRequire(import.meta.url);
const { name, version, description } = require('../package.json');
import pkg from '../package.json' with { type: 'json' };
const { name, version, description } = pkg;

/** @type {import('@gasket/core').Preset} */
export default {
Expand Down

0 comments on commit d433e48

Please sign in to comment.