Default https|http2 root property, cleanup plugin #1028

mmason2-godaddy · 2025-02-04T17:22:11Z

Summary

configure hook to see the root property by default if it's not set. This is a quality of life change to avoid errors when defining certs inside the https|http2 config properties.
Clean up plugin

Add configure hook to set a default for the root property inside the https|htt2 config options

Tests updated

packages/gasket-plugin-https/lib/configure.js

Co-authored-by: Andrew Gerard <63810935+agerard-godaddy@users.noreply.github.com>

add default root property, cleanup plugin

e485856

mmason2-godaddy requested a review from a team as a code owner February 4, 2025 17:22

mmason2-godaddy changed the title ~~add default root property, cleanup plugin~~ Default https|http2 root property, cleanup plugin Feb 4, 2025

CHANGELOG

1e3d162

agerard-godaddy reviewed Feb 4, 2025

View reviewed changes

packages/gasket-plugin-https/lib/configure.js Outdated Show resolved Hide resolved

Update packages/gasket-plugin-https/lib/configure.js

8c15e3b

Co-authored-by: Andrew Gerard <63810935+agerard-godaddy@users.noreply.github.com>

mmason2-godaddy requested a review from agerard-godaddy February 4, 2025 17:33

agerard-godaddy approved these changes Feb 4, 2025

View reviewed changes

kbader-godaddy approved these changes Feb 4, 2025

View reviewed changes

mmason2-godaddy merged commit 0526fb1 into main Feb 4, 2025
2 checks passed

mmason2-godaddy deleted the https-plugin-tuneup branch February 4, 2025 17:44