-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PFX-445] - @gasket/cli Jest refactor #667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job with this port 🥇
I did notice several .mock.calls
lookups which I think we can avoid now with Jest. There are probably others like it in the other packages, so let's just tackle that in a separate cleanup pass.
I'm not sure how you would remove |
* refactoring tests * init hook refactor * refactor apply-preset-config,cli-version,create-hooks * working commit * global-prompts refactor * index, install-modules, link-modules refactor * /actions test refactors * jest refactor * scaffold dir jest refactor * jest refactor files * finish unti test refactor * fix lint errors, update npm scripts, remove integration tests, remove devDeps * fix cli devDeps, lockfile (cherry picked from commit 9e657c6)
Summary
Changelog
Test Plan