Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFX-445] - @gasket/cli Jest refactor #667

Merged
merged 16 commits into from
Jan 24, 2024
Merged

[PFX-445] - @gasket/cli Jest refactor #667

merged 16 commits into from
Jan 24, 2024

Conversation

mmason2-godaddy
Copy link
Contributor

@mmason2-godaddy mmason2-godaddy commented Jan 23, 2024

Summary

Changelog

  • @gasket/cli Jest refactor

Test Plan

  • Refactored.....tests

@mmason2-godaddy mmason2-godaddy requested a review from a team as a code owner January 23, 2024 22:13
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
assertion-error REMOVED 1.1.0 -
chai REMOVED 4.3.6 -
check-error REMOVED 1.0.2 -
fetch-mock REMOVED 9.11.0 -
get-func-name REMOVED 2.0.2 -
is-subset REMOVED 0.1.1 -
loupe REMOVED 2.3.4 -
memorystream REMOVED 0.3.1 -
npm-run-all REMOVED 4.1.5 -
pathval REMOVED 1.1.1 -
pidtree REMOVED 0.3.1 -
querystring REMOVED 0.2.1 -
std-mocks REMOVED 1.0.1 -
string.prototype.padend REMOVED 3.1.3 -

Copy link
Contributor

@agerard-godaddy agerard-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with this port 🥇

I did notice several .mock.calls lookups which I think we can avoid now with Jest. There are probably others like it in the other packages, so let's just tackle that in a separate cleanup pass.

@mmason2-godaddy
Copy link
Contributor Author

mmason2-godaddy commented Jan 24, 2024

Nice job with this port 🥇

I did notice several .mock.calls lookups which I think we can avoid now with Jest. There are probably others like it in the other packages, so let's just tackle that in a separate cleanup pass.

I'm not sure how you would remove mock.calls. You could restructure the test to only use toHaveBeenCalledWith. For this task if args was present I just refactored to mock.calls. 👍

@mmason2-godaddy mmason2-godaddy merged commit 9e657c6 into main Jan 24, 2024
4 checks passed
@mmason2-godaddy mmason2-godaddy deleted the PFX-445 branch January 24, 2024 16:27
agerard-godaddy pushed a commit that referenced this pull request Jan 24, 2024
* refactoring tests

* init hook refactor

* refactor apply-preset-config,cli-version,create-hooks

* working commit

* global-prompts refactor

* index, install-modules, link-modules refactor

* /actions test refactors

* jest refactor

* scaffold dir jest refactor

* jest refactor files

* finish unti test refactor

* fix lint errors, update npm scripts, remove integration tests, remove devDeps

* fix cli devDeps, lockfile

(cherry picked from commit 9e657c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants