Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFX-398] - Align lifecycle contexts #669

Merged
merged 4 commits into from
Jan 31, 2024
Merged

[PFX-398] - Align lifecycle contexts #669

merged 4 commits into from
Jan 31, 2024

Conversation

kbader-godaddy
Copy link
Contributor

Summary

We have some lifecycles that do not conform to the context object pattern we have in place for many other lifecycles.

The reason for utilizing this context object is to enable the execution of these lifecycle methods under two distinct scenarios:

  1. During build time, when there is no request object available.
  2. During run time, when the request object becomes available.

Changelog

Align lifecycle contexts.

Test Plan

Tests have been updated.

@kbader-godaddy kbader-godaddy requested review from kinetifex and a team as code owners January 31, 2024 16:29
@kbader-godaddy kbader-godaddy self-assigned this Jan 31, 2024
@kbader-godaddy kbader-godaddy requested review from a team January 31, 2024 16:30
@agerard-godaddy agerard-godaddy added the version 7 Change targeted for version 7 label Jan 31, 2024
@kbader-godaddy kbader-godaddy merged commit 1e1d4eb into v7 Jan 31, 2024
4 checks passed
@kbader-godaddy kbader-godaddy deleted the PFX-398 branch January 31, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version 7 Change targeted for version 7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants