-
Notifications
You must be signed in to change notification settings - Fork 112
Read email addresses, phone numbers, postal addresses and instant messaging #9
base: master
Are you sure you want to change the base?
Conversation
ened
commented
Jun 27, 2018
- the example now links to the simple_permissions plugin in order to gain access to the users address book
- the dart class now returns a new data structure
… messenger accounts of a contact.
Very nice! |
BTW, just noticed I left a incorrect simple_permissions dependency in there. Once https://github.com/Ethras/flutter_simple_permissions/pull/19 is merged and a new plugin version is released, I will update the PR. |
Sounds great. I had been using a custom contact service plugin and it was such a pain and hack to do what I was wanting with this plugin |
@ened I have actually had better luck with simple_permissions instead of flutter_simple_permissions btw |
@AppleEducate I believe those two are the same. |
@ened I took what you did on your fork and merged the fields from flutter_contacts and updated the example. what do you think? |
Very cool! I'll probably get around to review the code on the weekend. |
@AppleEducate not sure yet - what is the intention of removing @goderbauer Do you have comments? |
@ened I can try to add it back but it was throwing Everytime a IMS returned with data when I selected a contact. If it was null it didn't crash. It is a weird bug. I'll clean up the PR |
@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August. |
Will do. It was also happening on you version too. I will try to find verbose logs because when it happens it does not provide any debug or crash info and just says lost connection to device. If you select a contact without IMS it doesn't crash. I'll keep exploring it
Rody Davis Jr.
Full Stack Mobile Developer
Github | Website | Appstore | LinkedIn
Twitter | Facebook | YouTube
…On Jul 10, 2018, 11:30 PM -0400, Sebastian Roth ***@***.***>, wrote:
@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Is this pull request ever going to be merged? |
@ened @goderbauer |
I’ve been a using my dependency override for quite some time now |
I personally oppose this pull request, the beauty of this plugin is to pick your contact without any permission. I think it's better to create different/separate plugin if you need more detail about the contact with permission. |
I’ll make a separate plugin then, thank you |
Waiting for an update!!! |
@guyzk in the mean time you can use my fork of this plugin! I am already doing this |