Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: initial goreleaser #95

Merged
merged 4 commits into from
Dec 6, 2023
Merged

ci: initial goreleaser #95

merged 4 commits into from
Dec 6, 2023

Conversation

ethanholz
Copy link
Contributor

@ethanholz ethanholz commented Nov 13, 2023

WIP GoReleaser addition, does not include GitHub Action for release or container builds.

  • Container builds need to be determined and added
  • Addition of packaging for DEB and RPM will need to be determined (most likely we will need to add completion scripts)

@ethanholz ethanholz requested a review from taigrr November 29, 2023 19:10
@ethanholz
Copy link
Contributor Author

@taigrr Requesting review to see if this looks good for initial releases or if there are further comments and changes that we might want to make.

- WIP GoReleaser addition, does not include GitHub Action for release or
  container builds
- Changed to grlx-<type>-<os>-<arch>
- Updated universal binary releases
@ethanholz
Copy link
Contributor Author

Latest commit adds more robust naming. This PR only contains the changes for local runs of GoReleaser. One bug I am facing is a known issue with GoReleaser which is an issue with two git tags on the same commit (such as v0.0.17 and v1.0.0).

This can be handled by using this environment variable but a better solution will be needed in the long term. Additionally, we will need to add the official GitHub Action.

@ethanholz ethanholz marked this pull request as ready for review November 30, 2023 20:55
@ethanholz ethanholz requested a review from taigrr November 30, 2023 21:06
@taigrr
Copy link
Member

taigrr commented Dec 1, 2023

We won't be double tagging things in the future, this shouldn't be an issue

@taigrr taigrr merged commit dcede02 into gogrlx:master Dec 6, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants