Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thought config + thoughts. #426

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

MarkDaoust
Copy link
Contributor

No description provided.

@MarkDaoust MarkDaoust requested a review from Giom-V January 30, 2025 15:25
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Jan 30, 2025
Copy link

review-notebook-app bot commented Jan 30, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-01-30T15:35:40Z
----------------------------------------------------------------

Line #3.        contents='How can I simplify this? (Math.round(radius/pixelsPerMile * 10) / 10).toFixed(1);. Be concise.'

Can you remove the "be concise" part ? I added it recently because the model was too talkative, but I think it's ok now that we're not exposing the thoughts.


Copy link

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-01-30T15:35:41Z
----------------------------------------------------------------

Line #1.    # Second part is the response from the model

This cell also needs to be removed


@MarkDaoust
Copy link
Contributor Author

Fixed.

@Giom-V Giom-V merged commit 31f9d8a into google-gemini:main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants