Use non-experimental model name for 2.0 #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the flash-exp model references to drop the `-exp` suffix. Also switched each of these to use a model selector where it wasn't already configured. I haven't added any extra models to notebooks with the selector as I figure they should be tested, and I didn't do that, but we can do it in future updates if we wish.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
status:awaiting review
|
This should be covered by #435, I'll still review it afterwards |
|
I think there's still the open question about "isTemplate: true", and you're still adding dropdowns in some place I think I forgot, so up to you to decide if you want to bother with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the flash-exp model references to drop the
-expsuffix. Also switched each of these to use a model selector where it wasn't already configured.I haven't added any extra models to notebooks with the selector as I figure they should be tested, and I didn't do that, but we can do it in future updates if we wish.
And included
isTemplateso users (or us?) can link to specific models in Colab.