Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Imagen example to illustrate a book #468

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

Giom-V
Copy link
Collaborator

@Giom-V Giom-V commented Feb 20, 2025

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder component:quickstarts Issues/PR referencing quickstarts folder labels Feb 20, 2025
Copy link

review-notebook-app bot commented Feb 20, 2025

View / edit / reply to this conversation on ReviewNB

philschmid commented on 2025-02-20T17:49:29Z
----------------------------------------------------------------

Remove the cell output?


Copy link
Collaborator

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Examples! LGTM. But i think we should remove the images from the notebooks and add rendered ones via markdown hosted on the bucket. Each Image is ~1MB which is a lot.

@Giom-V Giom-V merged commit 3fc98c1 into google-gemini:main Feb 21, 2025
5 checks passed
@Giom-V Giom-V deleted the book-illustration branch February 21, 2025 08:27
Yousif-GO pushed a commit to Yousif-GO/cookbook that referenced this pull request Feb 23, 2025
* Adding a Imagen example to illustrate a book
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples Issues/PR referencing examples folder component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants