Add execution_id for resuming/skipping test independently. #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/718872113
branch
7 times, most recently
from
76b8372 to
0f716f9
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
cl/718872113
branch
from
0f716f9 to
056fad8
Compare
This is done by checking and writing base_workdir/test.execution_id with the execution_id. Given a test to run, we check whether the coverage dir (inside the workdir) exists and if the .execution_id stamp matches the current execution ID, then resume the progress if: - execution ID mismatch: the test was not run in this execution - create the coverage dir, run for the whole duration, and remove the coverage dir once finished. - execution ID matches but the coverage dir is missing: the test was done previously for this exeuction - skip running the test. - execution ID matches but the coverage dir exists: the test was run previously but interrupted - run for the duration based on the previously recorded running time in the workdir. One side-effect is that now the base `workdir.[shard]` directory is not cleaned up upon the completion. Instead, the workdirs inside are removed, but the .execution_id files there kept as tombstones and read by later executions. PiperOrigin-RevId: 721566201
copybara-service
bot
force-pushed
the
cl/718872113
branch
from
056fad8 to
44ac6c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add execution_id for resuming/skipping test independently.
This is done by checking and writing base_workdir/test.execution_id with the execution_id.
Given a test to run, we check whether the coverage dir (inside the workdir) exists and if the .execution_id stamp matches the current execution ID, then resume the progress if:
One side-effect is that now the base
workdir.[shard]directory is not cleaned up upon the completion. Instead, the workdirs inside are removed, but the .execution_id files there kept as tombstones and read by later executions.