Forcibly terminate the runner via if the previous watchdog abort attempt has timed out. #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
cl/732274940
branch
from
c0be2bf to
34ee9af
Compare
copybara-service
bot
changed the title
…mpt has timed out. The watchdog will send `SIGABRT` initially, and the registered signal handler will produce a crash report. However, this may occasionally deadlock if the crash happens within tcmalloc. To prevent this, the watchdog thread will forcibly terminate it after a timeout via `std::abort()` without a crash report. PiperOrigin-RevId: 732274940
copybara-service
bot
force-pushed
the
cl/732274940
branch
from
34ee9af to
2d48d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcibly terminate the runner via if the previous watchdog abort attempt has timed out.
The watchdog will send
SIGABRTinitially, and the registered signal handler will produce a crash report. However, this may occasionally deadlock if the crash happens within tcmalloc. To prevent this, the watchdog thread will forcibly terminate it after a timeout viastd::abort()without a crash report.