Improve no_destructor.h

[frederick-vs-ja]

1. Removed dependency on std::aligned_storage (which will be deprecated in C++23; see also P1413 Deprecate std::aligned_storage and std::aligned_union cplusplus/papers#197).
2. Removed redundant static_asserts.
3. Guaranteed the placement new-expression calls global operator new.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[frederick-vs-ja]

@googlebot I signed it!

[pwnall]

Thank you for this contribution! I appreciate the explanation and the link to the C++23 paper.

Can you please add back the static_asserts? If CI still passes with them, I'd like to merge this.

[marcushultman]

Any chance this can be picked up again?

[marcushultman]

@pwnall Would you mind re-reviewing this?

[frederick-vs-ja]

Most changes were superseded by commit 302786e.

@pwnall But I still think there're should be some pedantic changes:

• in order to use the placement new-expression, we should include <new> to obtain the correct the operator new overload (which is unfortunately not implicitly declared);
• as mentioned in the PR description, new should be prefixed with ::;
• per CWG2489, char arrays don't provide storage for objects and we should use unsignd char arrays instead, although IIUC, compilers support such storage-providing mechanism as an extension.