Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a loading animation to the osv iframe #1661

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

WeizhouRen
Copy link
Contributor

Added a spinner indicating iframe is loading. Fixes #1524

animation_demo.mov

Copy link

google-cla bot commented Feb 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hogo6002 hogo6002 self-requested a review February 24, 2025 23:18
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.58%. Comparing base (91f56a9) to head (2bb60ba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1661      +/-   ##
==========================================
+ Coverage   64.56%   64.58%   +0.01%     
==========================================
  Files         155      155              
  Lines       15997    15997              
==========================================
+ Hits        10329    10332       +3     
+ Misses       4984     4982       -2     
+ Partials      684      683       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hogo6002
Copy link
Contributor

hogo6002 commented Feb 24, 2025

Thanks for contributing!!! Could you please run ./scripts/run_formatters.sh locally to fix the formatting issue?

@WeizhouRen WeizhouRen force-pushed the iframe-loading branch 2 times, most recently from e081d07 to c032ebb Compare February 25, 2025 04:42
Signed-off-by: Weizhou Ren <willzhou0305@gmail.com>
Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hogo6002 hogo6002 requested a review from G-Rath February 25, 2025 05:09
@hogo6002 hogo6002 merged commit ad06fee into google:main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container scanning HTML loading animation
4 participants