feat(javareach): Supported nested JARs. #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oliverchang
commented
Feb 25, 2025
oliverchang
commented
- Support loading of dependencies from nested JAR files (e.g. BOOT-INF for Spring Boot applications)
- Add flag to enable profiler for debugging performance issues.
- Support loading of dependencies from nested JAR files (e.g. BOOT-INF for Spring Boot applications) - Add flag to enable profiler for debugging performance issues.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
- Coverage 64.56% 64.54% -0.02%
==========================================
Files 155 155
Lines 15997 15997
==========================================
- Hits 10329 10326 -3
- Misses 4984 4986 +2
- Partials 684 685 +1 ☔ View full report in Codecov by Sentry. |
cuixq
approved these changes
Feb 25, 2025
| // Extract the Main-Class specified in MANIFEST.MF: | ||
| // https://docs.oracle.com/javase/tutorial/deployment/jar/appman.html | ||
| const mainClass = "Main-Class:" | ||
| const startClass = "Start-Class:" |
There was a problem hiding this comment.
is there documentation about this? the above docs does not say anything about Start-Class
There was a problem hiding this comment.
I can't find any public documentation, as it seems to be an implementation detail of spring boot. i'll add a comment.
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| // class not found in this .jar. not an error. |
There was a problem hiding this comment.
is this the expected behaviour?
There was a problem hiding this comment.
yes, this is just needed for searching through classpaths for the relevant class. if it doesn't exist, we move on to searching the next one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.