Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move offline flags out of experimental mode #1664

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

hogo6002
Copy link
Contributor

This PR moves offline flags out of experimental mode and removes the deprecated experimental-call-analysis flag

@hogo6002 hogo6002 marked this pull request as ready for review February 25, 2025 06:15
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (4ef1b47) to head (fe61c22).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/osv-scanner/fix/main.go 0.00% 2 Missing and 1 partial ⚠️
cmd/osv-scanner/internal/helper/helper.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1664      +/-   ##
==========================================
+ Coverage   64.40%   64.57%   +0.17%     
==========================================
  Files         155      156       +1     
  Lines       16003    16001       -2     
==========================================
+ Hits        10307    10333      +26     
+ Misses       5007     4986      -21     
+ Partials      689      682       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq
Copy link
Contributor

cuixq commented Feb 26, 2025

@hogo6002 can you help to update the documentation as well? https://google.github.io/osv-scanner/experimental/

@hogo6002
Copy link
Contributor Author

@hogo6002 can you help to update the documentation as well? https://google.github.io/osv-scanner/experimental/

updated

@hogo6002 hogo6002 enabled auto-merge (squash) February 26, 2025 04:27
@hogo6002 hogo6002 disabled auto-merge February 26, 2025 04:27
@hogo6002 hogo6002 merged commit 7001129 into google:main Feb 26, 2025
13 checks passed
hogo6002 added a commit that referenced this pull request Feb 26, 2025
#1664 missed one experimental
flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants