feat(importer): prepare for selective strict mode enablement (staging) #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit explicitly sets strict mode on a per-repository basis. This change is a no-op until the importer's `--strict_validation` flag is also set to True, and it will then be a no-op for all sources other than the `cve-osv` one where we can trial having it enabled. Part of google#2188
oliverchang
approved these changes
Nov 8, 2024
hogo6002
reviewed
Nov 8, 2024
I'm opting to make things very explicit to avoid any nasty surprises, especially when the flag flip for the importer happens. |
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Nov 8, 2024
This only impacts sources that have `strict_validation` enabled for them, such as in google#2837 Part of google#2188
andrewpollock
added a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit explicitly sets strict mode on a per-repository basis. This change is a no-op until the importer's
--strict_validationflag is also set to True, which will still then be a no-op for all sources other thancve-osvwhere we can trial having it enabled.Part of #2188