feat(exporter): add a safe_upload_single function #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a file size delta function to prevent the unintended overwriting of a file with a significantly smaller one. It only uses it for the unified all.zip upload at present, as I'm not sure how to identify when to use it for the ecosystem-specific zip files as they seem to be bundled in with the individual record files.
andrewpollock
requested review from
oliverchang,
michaelkedar,
hogo6002,
cuixq,
jess-lowe and
another-rex
another-rex
approved these changes
Feb 28, 2025
This addresses reviewer feedback and moves the default value to a constant at the top of the file.
…to exporter_safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a file size delta function to prevent the unintended overwriting of a file with a significantly smaller one.
It only uses it for the unified all.zip upload at present, as I'm not sure how to identify when to use it for the ecosystem-specific zip files as they seem to be bundled in with the individual record files.