Fix #185: Support and use autogen-modules. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase? |
blackgnezdo
approved these changes
May 22, 2018
This makes it possible to generate tarballs without generated modules (which would be regenerated anyway when the package is build). See tensorflow/haskell#180 for an example of the issues that causes. For `Cabal-1.*`, this continues the behavior as before. Unfortunately, `hpack` requires `cabal-version: >=2.0` when you use its `generated-modules` or `generated-other-modules` fields. Our current set of LTSes that we support still includes `Cabal-1.*` (which I think is correct). Luckily we could work around that using `hpack`'s `verbatim` field to accomplish the same thing a little more verbosely. Additionally, I mitigated the situation a little by changing the Cabal test script to not `sdist` packages that we're not releasing (`proto-lens-{tests/benchmarks}`). This change required bumping `stack` to `1.7.1` in order to get new enough versions of `Cabal` and `hpack`. Happily, it greatly simplifies the steps for releasing our packages.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
* Fix google#185: Support and use autogen-modules. This makes it possible to generate tarballs without generated modules (which would be regenerated anyway when the package is build). See tensorflow/haskell#180 for an example of the issues that causes. For `Cabal-1.*`, this continues the behavior as before. Unfortunately, `hpack` requires `cabal-version: >=2.0` when you use its `generated-modules` or `generated-other-modules` fields. Our current set of LTSes that we support still includes `Cabal-1.*` (which I think is correct). Luckily we could work around that using `hpack`'s `verbatim` field to accomplish the same thing a little more verbosely. Additionally, I mitigated the situation a little by changing the Cabal test script to not `sdist` packages that we're not releasing (`proto-lens-{tests/benchmarks}`). This change required bumping `stack` to `1.7.1` in order to get new enough versions of `Cabal` and `hpack`. Happily, it greatly simplifies the steps for releasing our packages. * More README updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to generate tarballs without generated modules
(which would be regenerated anyway when the package is build).
See tensorflow/haskell#180 for an example of the issues that causes.
For
Cabal-1.*, this continues the behavior as before.Unfortunately,
hpackrequirescabal-version: >=2.0when you useits
generated-modulesorgenerated-other-modulesfields.Our current set of LTSes that we support still includes
Cabal-1.*(which I think is correct). Luckily we could work around that
using
hpack'sverbatimfield to accomplish the same thing a littlemore verbosely. Additionally, I mitigated the situation a little by changing
the Cabal test script to not
sdistpackages that we're not releasing(
proto-lens-{tests/benchmarks}).This change required bumping
stackto1.7.1in order to get new enoughversions of
Cabalandhpack. Happily, it greatly simplifiesthe steps for releasing our packages.
This change is