Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLint workflow. #476

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add HLint workflow. #476

merged 1 commit into from
Oct 1, 2024

Conversation

chungyc
Copy link
Member

@chungyc chungyc commented Sep 30, 2024

Adds a code scanning workflow using HLint. Suggestions and warnings are included inline for pull requests and the code scanning dashboard in the security tab. See https://github.com/haskell-actions/hlint-scan#examples for an example.

This sets up HLint to ignore warnings that would be triggered by the existing code. We would likely want to enable some of them, for example, Redundant $ to remove unnecessary $ operators. Others could be marked as permanently disabled. This could be done in future changes.

Resolves #279.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@blackgnezdo blackgnezdo merged commit d7fa2c7 into google:master Oct 1, 2024
11 checks passed
@blackgnezdo
Copy link
Collaborator

Looks awesome, thanks for finding this gem!

@chungyc chungyc deleted the hlint branch October 1, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hlint to proto-lens's CI
2 participants