Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more hints for HLint. #489

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Enable more hints for HLint. #489

merged 10 commits into from
Oct 11, 2024

Conversation

chungyc
Copy link
Member

@chungyc chungyc commented Oct 10, 2024

The specific hints that are enabled are Fuse foldr/map, Use :, Use camelCase, Use concatMap, Use maybe, Use newtype instead of data, and Use replicate.

These are the last of the hints I will be enabling, which seem uncontroversial enough. The rest range from those that I am ambivalent about (e.g., Eta reduce; point-free style is fine, but I don't feel that we need to strive to be point-free as much as possible) to those I think are a bad idea (e.g., Use <$; it's a generally obscure enough operator that isn't used enough in this code base for it to become naturally familiar with).

Copy link
Collaborator

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that all the enabled warnings are uncontroversial. Thanks for all these cleanups!

@blackgnezdo blackgnezdo merged commit 4df4073 into google:master Oct 11, 2024
11 checks passed
@chungyc chungyc deleted the hlint branch October 15, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants