Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.10 #494

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Support GHC 9.10 #494

merged 3 commits into from
Dec 3, 2024

Conversation

9999years
Copy link
Contributor

Copy link

google-cla bot commented Oct 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@blackgnezdo
Copy link
Collaborator

blackgnezdo commented Oct 29, 2024

Thanks for the fixes! Would you mind extending our CI build matrix to include 9.10? I'd be happy if you repurpose the cabal build with ghc 9.6 / cabal test for this. We already have 9.10 covered by Stack and I don't see ghc-9.10 in stackage yet.

Copy link
Collaborator

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if everything passes and the file noted removed.

@blackgnezdo
Copy link
Collaborator

Thanks @9999years !

Copy link
Collaborator

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @9999years

@blackgnezdo blackgnezdo merged commit c927e03 into google:master Dec 3, 2024
11 checks passed
@9999years 9999years deleted the ghc910 branch December 4, 2024 19:00
@edsko
Copy link
Contributor

edsko commented Dec 17, 2024

Thanks for doing this! Any chance of a release? :)

@blackgnezdo
Copy link
Collaborator

blackgnezdo commented Dec 18, 2024

I don't mind pushing the release button, but I'm not likely to find the time to do the version increment. We also got some awesome new features like protobuf editions support courtesy of @chungyc. I'd like somebody to note them down properly in the affected packages' changelogs.

@blackgnezdo
Copy link
Collaborator

Also, since we have a release of ghc-source-gen 0.4.6.0 up, we should be able to simplify this:

source-repository-package
type: git
location: https://github.com/google/ghc-source-gen
tag: 1f0ccfc5a236e349cd48c372deda373121cd9734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants