Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-06 make Firefox compatible #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

step-06 make Firefox compatible #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion step-06/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,10 @@ function signalingMessageCallback(message) {

} else if (message.type === 'candidate') {
peerConn.addIceCandidate(new RTCIceCandidate({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same logic is present in step-05/js/main.js -- could you add the change there as well?

sdpMLineIndex: message.label,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Order properties alphabetically.

  candidate: message.candidate,
  sdpMid: message.id,
  sdpMLineIndex: message.label,

sdpMid: message.id,
candidate: message.candidate
}));
}));// Firefox compatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add "Firefox compatible". We want to make it compatible with all browsers.


} else if (message === 'bye') {
// TODO: cleanup RTC connection?
Expand Down