[glyphs-reader/font] ignore duplicate global metrics, first wins

matches glyphsLib behavior https://github.com/googlefonts/glyphsLib/blob/c4db6b981d577f456d64ebe9993818770e170454/Lib/glyphsLib/classes.py#L1758
googlefonts · Feb 14, 2025 · 7da4c32 · 7da4c32
1 parent 92b89b3
commit 7da4c32
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/glyphs-reader/src/font.rs b/glyphs-reader/src/font.rs
@@ -2534,7 +2534,13 @@ impl TryFrom<RawFont> for Font {
                             metric_names.get(&idx).map(|name| (name.clone(), value))
                         })
                         .filter(|(_, metric)| !metric.is_empty())
-                        .collect(),
+                        .fold(BTreeMap::new(), |mut acc, (name, value)| {
+                            // only insert a metric if one with the same name hasn't been added
+                            // yet; matches glyphsLib's behavior where the first duplicate wins
+                            // https://github.com/googlefonts/fontc/issues/1269
+                            acc.entry(name).or_insert(value);
+                            acc
+                        }),
                     number_values: from
                         .numbers
                         .iter()