Rename Feature -> Construct

Reading through the OpenType spec today, and learning that feature is a term of art.
googlefonts · Mar 22, 2024 · d68387c · d68387c
1 parent e634af9
commit d68387c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/fontir/src/error.rs b/fontir/src/error.rs
@@ -156,8 +156,8 @@ pub enum WorkError {
     },
     #[error("No source with layerName \"{0}\" exists")]
     NoSourceForName(String),
-    #[error("Source file contained a feature we don't yet support: {0}")]
-    UnsupportedFeature(String),
+    #[error("Source file contained a construct we don't yet support: {0}")]
+    UnsupportedConstruct(String),
 }
 
 /// An async work error, hence one that must be Send

diff --git a/fontra2fontir/src/toir.rs b/fontra2fontir/src/toir.rs
@@ -23,9 +23,9 @@ pub(crate) fn to_ir_static_metadata(
         .axes
         .iter()
         .map(|a| match a {
-            crate::fontra::FontraAxis::Discrete(_) => Err(WorkError::UnsupportedFeature(format!(
-                "discrete axis {a:?}"
-            ))),
+            crate::fontra::FontraAxis::Discrete(_) => Err(WorkError::UnsupportedConstruct(
+                format!("discrete axis {a:?}"),
+            )),
             crate::fontra::FontraAxis::Continuous(a) => Ok(a),
         })
         .map(|a| {