Name 'standard' axes to match fonttools #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
changed the title
anthrotype
force-pushed
the
standard-axis-names
branch
from
83a4224 to
b34ebc6
Compare
anthrotype
changed the title
|
reproducer: https://github.com/googlefonts/fontc/actions/runs/11326676896/job/31496101459?pr=1032#step:4:433 Diff < left / right > :
[
< "Weight",
< "Width",
< "Italic",
< "Slant",
< "Optical Size",
> "weight",
> "width",
> "italic",
> "slant",
> "optical",
"foobarbaz",
] |
…naming conventions Parf of fixing #1020
|
after this PR, https://github.com/weiweihuanghuang/Work-Sans Work-Sans-Italic.glyphs reports identical name, fvar and STAT tables in ttx_diff.py |
rsheeter
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing #1020
This makes so that we follow fonttools' axis naming of a special group of registered axes, conventions still used by some old source files.
The remaining part of #1020 requires norad to support parsing of
<labelname>element.