fix Glyphs 2 sources with implicit axes always getting indirect HVAR #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
glyphs2-implicit-axes-direct-hvar
branch
from
ab1c3bf to
b3a20e9
Compare
anthrotype
force-pushed
the
glyphs2-implicit-axes-direct-hvar
branch
from
b3a20e9 to
a0d4725
Compare
cmyr
approved these changes
Feb 13, 2025
| "-", | ||
| "!" | ||
| ); | ||
| .appVersion = "3340"; |
There was a problem hiding this comment.
no, that's simply saying this particular glyphs2 source file was serialized by Glyphs 3 (3340). you can 'save as'. I don't have a Glyphs 2.app any more.
The .formatVersion key stores the source format version, it's omitted in Glyphs 2 (defaults to 2 in fact).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256
The first commit reproduces the bug, followed by actual fix