[features] Share more code, do less work #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to compile both marks & kern we need to have already compiled the GSUB table. To avoid doing this repeatedly, we now compile it immediately after parsing the AST, and then make it available to the mark & kern feature writers. We also similarly store the explicit GDEF classes, if they were in the FEA, and try to share more code between mark & kern generation in general.
cmyr
force-pushed
the
share-compiled-gsub
branch
from
ce127af to
cfbcbd8
Compare
This is more efficient, and better matches what we're doing in kern which will let us more easily share code.
cmyr
force-pushed
the
share-compiled-gsub
branch
from
cfbcbd8 to
df05d78
Compare
dfrg
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to compile both marks & kern we need to have already compiled the GSUB table. To avoid doing this repeatedly, we now compile it immediately after parsing the AST, and then make it available to the mark & kern feature writers.
We also similarly store the explicit GDEF classes, if they were in the FEA, and try to share more code between mark & kern generation in general.
This also includes a commit that makes us convert glyph names to glyph ids earlier in the marks compilation process, which similarly helps us share more code with kerning.
(all of this is motivated by work on abvm and blwm)