Start to parse Fontra components #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
changed the title
cmyr
approved these changes
Feb 6, 2024
| @@ -78,7 +180,7 @@ pub(crate) struct FontraSource { | |||
| #[serde(rename = "layerName")] | |||
| pub(crate) layer_name: String, | |||
| #[serde(default)] | |||
| pub(crate) location: HashMap<Tag, f64>, | |||
| pub(crate) location: HashMap<String, f64>, | |||
There was a problem hiding this comment.
if this String has any specific meaning (is it supposed to be a tag, or a human readable name, or what?) a comment would be useful.
There was a problem hiding this comment.
I think it'll help if I newtype some of the name fields that are used as identifiers. HashMap<AxisName, f64>, much like the <Tag, f64> version. Aside: I wish it was the tag.
There was a problem hiding this comment.
I will do this in a followon
dfrg
approved these changes
Feb 6, 2024
Sersery0606
reviewed
Mar 6, 2024
Sersery0606
reviewed
Mar 6, 2024
Sersery0606
reviewed
Mar 6, 2024
Sersery0606
reviewed
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet turned into IR
Components require a better version of string to filename so that is added, fixes #688.