fea-rs: conditional compilation of GPOS & GSUB #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Feb 6, 2024
| /// as the number of errors you expect to encounter. | ||
| /// | ||
| /// [`DiagnosticSet`]: crate::DiagnosticSet | ||
| pub fn max_error_messages(mut self, max_n_errors: usize) -> Self { |
There was a problem hiding this comment.
Optional, I think I might have expected an option (-1?) to print all of them
There was a problem hiding this comment.
this is my fault for trying to be funny in my docs. Can update to just say usize::MAX, the joke isn't good anyway 😅
rsheeter
approved these changes
Feb 6, 2024
This is in anticipation of adding additional Opts (specifically for only compiling certain tables) and I'd like `Opts` to be the source of truth for user configuration.
Opts are now available during compilation. This also adds (currently unused) options to specify if you want gpos & gsub to be compiled.
This is a fairly quick pass, and if future profiling suggests it is useful we could be more fine-grained in deciding what code to skip executing. In particular we still perform the full validation pass, where we could skip some work there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes these options through to the compile step, which will skip processing the relevant statements if the corresponding table is not desired.