[fontbe] Write out glyph order when --emit-debug is set #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Feb 6, 2024
fontbe/src/features.rs
Outdated
| @@ -393,22 +393,27 @@ impl FeatureCompilationWork { | |||
| } | |||
| } | |||
|
|
|||
| fn write_glyph_order(context: &Context, glyphs: &GlyphOrder) { | |||
There was a problem hiding this comment.
Nit: write_debug_glyph_order would be more consistent
rsheeter
approved these changes
Feb 6, 2024
rsheeter
approved these changes
Feb 6, 2024
This is useful for writing certain tests for fea-rs, since I require a glyph order in order to compile features.
cmyr
force-pushed
the
debug-glyph-order
branch
from
8286ccf to
8fee36e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for writing certain tests for fea-rs, since I require a glyph order in order to compile features.