Kern alignment #727
Merged
Kern alignment #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Mar 7, 2024
fontbe/src/kern.rs
Outdated
| &side1_glyph_to_group_map, | ||
| &side2_glyph_to_group_map, | ||
| ); | ||
| log::info!("got aligned value {value} for kern pair {pair:?}"); |
There was a problem hiding this comment.
maybe log::info level would be too noisy for this, debug might work better
There was a problem hiding this comment.
oh good call, I just added this for my personal edification so I could see if what was happening looked sensible, I think we can just remove it.
This was way more confusing than it should've been, but ultimately I believe this is correct. It brings the oswald diff from 8.6k/3.3k to 7.5k/2.2k, which is very promising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was way more confusing than it should've been, but ultimately I
believe this is correct. It brings the oswald diff from 8.6k/3.3k to
7.5k/2.2k, which is very promising.
I do now see one additional difference in kerning, which is that in some cases we have identical values at each position in the designspace; this means we don't need to store deltas at all. We're also sometimes storing explicit 0 values, which is also unnecessary.
CI is currently broken, pending #726.
this is based on #725, which will go in when CI is fixed.