feat: Add support to emit Metrics same as Traces via OTEL #456
+124
−27
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package metrics | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "go.opentelemetry.io/otel" | ||
| "go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc" | ||
| "go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp" | ||
| "go.opentelemetry.io/otel/sdk/metric" | ||
| sdkresource "go.opentelemetry.io/otel/sdk/resource" | ||
| ) | ||
|
|
||
| func InitMetrics(enableGRPCCollector bool, enableHTTPCollector bool) (*metric.MeterProvider, error) { | ||
| extraResources, _ := sdkresource.New( | ||
| context.Background(), | ||
| sdkresource.WithOS(), | ||
| sdkresource.WithProcess(), | ||
| sdkresource.WithContainer(), | ||
| sdkresource.WithHost(), | ||
| sdkresource.WithAttributes(), | ||
| ) | ||
| resource, _ := sdkresource.Merge( | ||
| sdkresource.Default(), | ||
| extraResources, | ||
| ) | ||
|
|
||
| options := []metric.Option{metric.WithResource(resource)} | ||
|
|
||
| if enableGRPCCollector { | ||
| exporter, err := otlpmetricgrpc.New(context.Background()) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| options = append(options, metric.WithReader(metric.NewPeriodicReader(exporter))) | ||
|
There was a problem hiding this comment. There are options we can configure at the PeriodicReader, like the frequency, but I didn't want to make configuration too complex, and the defaults are sensible. |
||
| } | ||
|
|
||
| if enableHTTPCollector { | ||
| exporter, err := otlpmetrichttp.New(context.Background()) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| options = append(options, metric.WithReader(metric.NewPeriodicReader(exporter))) | ||
| } | ||
|
|
||
| meterProvider := metric.NewMeterProvider(options...) | ||
|
|
||
| // Register as global meter provider so that it can be used via otel.Meter | ||
| // and accessed using otel.GetMeterProvider. | ||
| // Most instrumentation libraries use the global meter provider as default. | ||
| // If the global meter provider is not set then a no-op implementation | ||
| // is used, which fails to generate data. | ||
| otel.SetMeterProvider(meterProvider) | ||
|
|
||
| return meterProvider, nil | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnaryServerInterceptor and StreamServerInterceptor have been deprecated in favour of NewServerHandler()