This repository has been archived by the owner on Jan 15, 2023. It is now read-only.
Add import comments #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Oct 1, 2018
parser/parser.go
Outdated
| @@ -5,8 +5,8 @@ | |||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
|
|
|||
| // Package parser implements a parser for Gosh source files. | |||
| package parser | |||
| // package parser // import "gosh-lang.org/gosh/parser" implements a parser for Gosh source files. | |||
There was a problem hiding this comment.
package comment should be of the form "Package parser ..."
scanner/scanner.go
Outdated
| @@ -5,8 +5,8 @@ | |||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
|
|
|||
| // Package scanner implements a scanner for Gosh source text. | |||
| package scanner | |||
| // package scanner // import "gosh-lang.org/gosh/scanner" implements a scanner for Gosh source text. | |||
There was a problem hiding this comment.
package comment should be of the form "Package scanner ..."
tokens/tokens.go
Outdated
| @@ -5,8 +5,8 @@ | |||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
|
|
|||
| // Package tokens defines constants representing the lexical tokens of the Gosh programming language. | |||
| package tokens | |||
| // package tokens // import "gosh-lang.org/gosh/tokens" defines constants representing the lexical tokens of the Gosh programming language. | |||
There was a problem hiding this comment.
package comment should be of the form "Package tokens ..."
parser/parser_test.go
Outdated
| @@ -257,7 +257,7 @@ func TestParser(t *testing.T) { | |||
| }) | |||
| require.NoError(t, err) | |||
| p := New(s, &Config{ | |||
| // crashOnError: true, | |||
| // crashOnError: true, | |||
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 4 4
Lines 1002 1002
=======================================
Hits 761 761
Misses 209 209
Partials 32 32Continue to review full report at Codecov.
|
|
#20 introduced exactly the same changes. 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Vanity import paths aren't mandatory
Solution: Add comments to enforce them. Closes #19