Added stub for parsing Nokia Suite csv file. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the most essential parts for parsing .csv file created by Nokia Suite in a way that should be compatible with the rest of the software. To incorporate it fully probably additional argument should be parsed (input_type) and kind of a dropdown list added on web interface. Also small variables changes should be made to keep everything clear.
|
Nice PR. Thanks. I will integrate your code with updated web interface soon. Do you have any CSV sample you can attach to an issue so I can test it? |
|
Added sample CSV to the repository. Changed phone numbers and most of texts but format is identical to what Nokia Suite produces. |
reavertm
reviewed
Jun 5, 2018
| date = sms.get('date') | ||
| type = sms.get('type') # 1 = received / 2 = sent | ||
| body = sms.get('body') | ||
| elif input_type == 'csv: |
There was a problem hiding this comment.
Untermined string constant right here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had the same problem but migrating from Symbian Nokia. I got text messages as csv file and managed to get them on my new WP using parts of your code (mainly hash creation). So I fought maybe you'd be interested in incorporating additional functionality.
I added the most essential parts for parsing csv file created by Nokia Suite in a way that should be compatible with the rest of the software. To incorporate it fully probably additional argument should be parsed (input_type) and kind of a dropdown list added on web interface. Also small variables changes should be made to keep everything clear.
Sorry for not providing full, working code but I'm far from being proficient in arguments parsing and web interface (in fact not even a beginner) and I use Python occasionally. So I decided it is safer to just show you additional thing that can be added to your code and may be useful for someone else out there on the Internet.