backend: improve parse function performance in gtime package #1238
+180
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
parse
function is used inParseDuration
andParseInterval
. Those methods is used in many places ingrafana/grafana
.ParseDuration
is especially used in settings.go to parse the config. Improving their performance will result a better start time and less memory usage.This is also a complimentary PR for #1237
This method is using when we get the request and parse the request data into a model. Its overall impact to memory consumption is small comparing to the other parts. But considering that it's been used in many places total impact is still important.
Also I improved it in all areas that means, less allocations, less gc overheat, faster calculations.
Here is the benchmark comparison: