TraceQL metrics tests #4802
Open
TraceQL metrics tests #4802
+950
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslan-mikhailov
force-pushed
the
trace-ql-metrics-tests
branch
2 times, most recently
from
a09acad to
25c70d4
Compare
ruslan-mikhailov
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer,
javiermolinar and
carles-grafana
as code owners
| @@ -55,6 +55,14 @@ sendLoop: | |||
| for _, query := range []string{ | |||
| "{} | rate()", | |||
| "{} | compare({status=error})", | |||
| "{} | count_over_time()", | |||
There was a problem hiding this comment.
Can we include aggregations here?
{span.http.status_code = 500} | count_over_time() by (resource.service.name)
We should also test metrics with no matches
{span.foo = bar} | count_over_time() by (resource.service.name)
ruslan-mikhailov
force-pushed
the
trace-ql-metrics-tests
branch
from
d337963 to
a7331cc
Compare
ruslan-mikhailov
force-pushed
the
trace-ql-metrics-tests
branch
from
a7331cc to
be455bc
Compare
| } { | ||
| t.Run(query, func(t *testing.T) { | ||
| callQueryRange(t, tempo.Endpoint(tempoPort), query, debugMode) | ||
| queryRangeRes := callQueryRange(t, tempo.Endpoint(tempoPort), query, debugMode) |
There was a problem hiding this comment.
I think this test should be rewritten to a deterministic table-driven test asserting that the data returned is correct:
- MakeThriftBatch generates random data; this should be changed to something we can control
- We should ensure we have traces in the backend and in recent data to test the different aggregation layers
- We should test a comprehensive list of metrics with and without aggregation and check the correctnes of the returned series
ruslan-mikhailov
force-pushed
the
trace-ql-metrics-tests
branch
from
be455bc to
97af8be
Compare
|
+ Rebase from latest main and fix after rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves coverage of TraceQL metrics
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]