-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitHub workflows #156
Open
szkiba
wants to merge
9
commits into
master
Choose a base branch
from
152-refactor-github-workflows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+789
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablochacin
reviewed
Mar 21, 2025
args: build --clean --snapshot --single-target | ||
``` | ||
|
||
[Bats](https://github.com/bats-core/bats-core) (Bash Automated Testing System) scripts can be specified as integration tests. These will be executed in jobs running on `Linux` operating systems (with all go versions specified in the input). If any integration test script fails, the workflow will stop with an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have a bullet point also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it is just continuation of prev point
pablochacin
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
validate
andrelease
workflows, whose functionality has been extracted into thetooling-validate
andtooling-release
reusable workflows.The new workflows must be configured via mandatory repository variables:
GO_VERSION
The go version to use for the build.GO_VERSIONS
The go versions to use for running the tests. JSON string array (e.g.["1.24.x", "1.23.x"]
)PLATFORMS
Platforms to be used to run the tests. JSON string array (e.g.["ubuntu-latest","macos-latest"]
)K6_VERSIONS
The k6 versions to be used for integration tests. JSON string array (e.g.["v0.57.0","v0.56.0"]
)GOLANGCI_LINT_VERSION
The golangci-lint version to use for static analysis.GORELEASER_VERSION
The version of GoReleaser to use for builds and releases.The new workflows use the following repository secrets:
DOCKER_USER
Username to use for pushing Docker images to Docker Hub.DOCKER_PASS
Token to use for pushing Docker images to Docker Hub.CODECOV_TOKEN
Token to be used to upload test coverage data to Codecov.