Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrailsWebConsole feature should use grails-web-console not grails-console #511

Closed
jamesfredley opened this issue Feb 14, 2025 · 3 comments · Fixed by #530
Closed

GrailsWebConsole feature should use grails-web-console not grails-console #511

jamesfredley opened this issue Feb 14, 2025 · 3 comments · Fixed by #530
Assignees

Comments

@jamesfredley
Copy link
Contributor

public void apply(GeneratorContext generatorContext) {
generatorContext.addDependency(Dependency.builder()
.groupId("org.grails.plugins")
.lookupArtifactId("grails-console")
.runtimeOnly());

grails-console should be grails-web-console

grails-web-console is not currently in grails-bom

@jamesfredley
Copy link
Contributor Author

jamesfredley commented Feb 14, 2025

@jdaugherty What are your thoughts on adding org.grails.plugins:grails-web-console to grails-bom? org.grails:grails-console does exist in grails-bom

Option B is to add it to pom.xml and reference it from there instead:

<dependencies>
<dependency>
<groupId>org.grails</groupId>
<artifactId>grails-gradle-plugin</artifactId>
<version>7.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>hibernate5</artifactId>
<version>9.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>cache</artifactId>
<version>8.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>cache-ehcache</artifactId>
<version>3.0.0</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>database-migration</artifactId>
<version>6.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>quartz</artifactId>
<version>3.0.0</version>
</dependency>
<dependency>
<groupId>org.asciidoctor.jvm.convert</groupId>
<artifactId>asciidoctor-gradle-jvm</artifactId>
<version>4.0.1</version>
</dependency>
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
<version>7.0.5.Final</version>
</dependency>
<dependency>
<groupId>org.mongodb</groupId>
<artifactId>mongodb-driver-sync</artifactId>
<version>4.11.3</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>views-gradle</artifactId>
<version>4.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>embedded-mongodb</artifactId>
<version>2.0.1</version>
</dependency>
<dependency>
<groupId>com.github.johnrengelman.shadow</groupId>
<artifactId>shadow</artifactId>
<version>7.1.1</version>
</dependency>
<dependency>
<groupId>org.grails.plugins</groupId>
<artifactId>grails-console</artifactId>
<version>2.1.1</version>
</dependency>
<dependency>
<groupId>com.github.erdi</groupId>
<artifactId>webdriver-binaries-gradle-plugin</artifactId>
<version>3.2</version>
</dependency>
<dependency>
<groupId>org.zeroturnaround</groupId>
<artifactId>gradle-jrebel-plugin</artifactId>
<version>1.2.0</version>
</dependency>
<dependency>
<groupId>com.bertramlabs.plugins</groupId>
<artifactId>asset-pipeline-gradle</artifactId>
<version>5.0.5</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.11.4</version>
</dependency>
<dependency>
<groupId>io.micronaut</groupId>
<artifactId>micronaut-http-client</artifactId>
<version>4.6.6</version>
</dependency>
<dependency>
<groupId>io.micronaut.serde</groupId>
<artifactId>micronaut-serde-jackson</artifactId>
<version>2.11.0</version>
</dependency>
</dependencies>

@jamesfredley jamesfredley added this to the grails:7.0.0-M2 milestone Feb 14, 2025
@jdaugherty jdaugherty self-assigned this Feb 20, 2025
@jdaugherty
Copy link
Contributor

We should add it to the pom. We don't want to include plugins in the grails-bom unless they're considered part of core.

@jdaugherty
Copy link
Contributor

The console that's in the bom should be the grails gradle console.

@jamesfredley jamesfredley self-assigned this Feb 20, 2025
@jdaugherty jdaugherty removed their assignment Feb 20, 2025
@jamesfredley jamesfredley moved this to In Progress in Grails 7 Feb 20, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Grails 7 Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants